netdev - Re: [PATCH] ipv6: don't call addrconf_dst

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131231035718.GB27636@order.stressinduktion.org>
Date:	Tue, 31 Dec 2013 04:57:18 +0100
From:	Hannes Frederic Sowa <hannes@...essinduktion.org>
To:	David Miller <davem@...emloft.net>
Cc:	gaofeng@...fujitsu.com, kumaran.4353@...il.com,
	netdev@...r.kernel.org, chenweilong@...wei.com
Subject: Re: [PATCH] ipv6: don't call addrconf_dst_alloc again when enable lo

On Wed, Jun 19, 2013 at 11:05:32PM -0700, David Miller wrote:
> From: Gao feng <gaofeng@...fujitsu.com>
> Date: Sun, 16 Jun 2013 11:14:30 +0800
> 
> > If we disable all of the net interfaces, and enable
> > un-lo interface before lo interface, we already allocated
> > the addrconf dst in ipv6_add_addr. So we shouldn't allocate
> > it again when we enable lo interface.
> > 
> > Otherwise the message below will be triggered.
> > unregister_netdevice: waiting for sit1 to become free. Usage count = 1
> > 
> > This problem is introduced by commit 25fb6ca4ed9cad72f14f61629b68dc03c0d9713f
> > "net IPv6 : Fix broken IPv6 routing table after loopback down-up"
> > 
> > Signed-off-by: Gao feng <gaofeng@...fujitsu.com>
> 
> This is the second such regression added by that commit :-/
> 
> Applied and queue up for -stable, thanks.

Hmm, and this change also has a regression and breaks the original fix. :/

https://bugzilla.kernel.org/show_bug.cgi?id=67951

I tried to track it down but it seems pretty complicated. Maybe we have to
special-case the take-down of the loopback device.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html