netdev - Re: [PATCH 4/5] alx: add alx_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1388663813.22017.12.camel@deadeye.wl.decadent.org.uk>
Date:	Thu, 2 Jan 2014 11:56:53 +0000
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	David Miller <davem@...emloft.net>
CC:	<sd@...asysnail.net>, <johannes@...solutions.net>,
	<netdev@...r.kernel.org>
Subject: Re: [PATCH 4/5] alx: add alx_get_stats operation

On Wed, 2014-01-01 at 22:27 -0500, David Miller wrote:
> From: Sabrina Dubroca <sd@...asysnail.net>
> Date: Thu,  2 Jan 2014 00:40:27 +0100
> 
> > +	spin_lock(&alx->stats_lock);
> > +
> > +	__alx_update_hw_stats(&alx->hw);
> 
> Please use something like the linux/u64_stats_sync.h stuff rather
> than spin locking.

I don't think that'sa useful, as we can have multiple writers
(concurrent calls to get_stats).  And there is really no harm in using a
spinlock to serialise get_stats calls.  The u64_stats API is good for
statistics updated from the data path.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html