netdev - Re: [PATCH 3/5] alx: add stats update function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1388663574.22017.8.camel@deadeye.wl.decadent.org.uk>
Date:	Thu, 2 Jan 2014 11:52:54 +0000
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Stephen Hemminger <stephen@...workplumber.org>
CC:	Sabrina Dubroca <sd@...asysnail.net>, <davem@...emloft.net>,
	<johannes@...solutions.net>, <netdev@...r.kernel.org>
Subject: Re: [PATCH 3/5] alx: add stats update function

On Wed, 2014-01-01 at 21:55 -0800, Stephen Hemminger wrote:
> On Thu,  2 Jan 2014 00:40:26 +0100
> Sabrina Dubroca <sd@...asysnail.net> wrote:
> 
> > diff --git a/drivers/net/ethernet/atheros/alx/hw.h b/drivers/net/ethernet/atheros/alx/hw.h
> > index 207bcc6..97e8731 100644
> > --- a/drivers/net/ethernet/atheros/alx/hw.h
> > +++ b/drivers/net/ethernet/atheros/alx/hw.h
> > @@ -482,6 +482,8 @@ struct alx_hw {
> >  
> >  	/* PHY link patch flag */
> >  	bool lnk_patch;
> > +
> > +	struct alx_hw_stats stats;
> >  };
> 
> Why do you need this to be part of the hw struct?
> It doesn't need to be persistent.
> couldn't the callers just pass it on the stack.

Oh come on, how is that going to work when the hardware counters are
read-to-clear?

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html