netdev - Re: [PATCH 1/5] alx: add a hardware stats structure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1388663531.22017.7.camel@deadeye.wl.decadent.org.uk>
Date:	Thu, 2 Jan 2014 11:52:11 +0000
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Sabrina Dubroca <sd@...asysnail.net>
CC:	<davem@...emloft.net>, <johannes@...solutions.net>,
	<netdev@...r.kernel.org>
Subject: Re: [PATCH 1/5] alx: add a hardware stats structure

On Thu, 2014-01-02 at 00:40 +0100, Sabrina Dubroca wrote:
> Signed-off-by: Sabrina Dubroca <sd@...asysnail.net>
> ---
>  drivers/net/ethernet/atheros/alx/hw.h | 58 +++++++++++++++++++++++++++++++++++
>  1 file changed, 58 insertions(+)
> 
> diff --git a/drivers/net/ethernet/atheros/alx/hw.h b/drivers/net/ethernet/atheros/alx/hw.h
> index 96f3b43..207bcc6 100644
> --- a/drivers/net/ethernet/atheros/alx/hw.h
> +++ b/drivers/net/ethernet/atheros/alx/hw.h
> @@ -381,6 +381,64 @@ struct alx_rrd {
>  				 ALX_ISR_RX_Q6 | \
>  				 ALX_ISR_RX_Q7)
>  
> +/* Statistics counters collected by the MAC */
> +struct alx_hw_stats {
> +	/* rx */
> +	unsigned long rx_ok;
[...]

Use u64 for all of these.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html