netdev - Re: [PATCH 3/5] alx: add stats update function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140101215509.4a9f139c@nehalam.linuxnetplumber.net>
Date:	Wed, 1 Jan 2014 21:55:09 -0800
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Sabrina Dubroca <sd@...asysnail.net>
Cc:	davem@...emloft.net, johannes@...solutions.net,
	netdev@...r.kernel.org
Subject: Re: [PATCH 3/5] alx: add stats update function

On Thu,  2 Jan 2014 00:40:26 +0100
Sabrina Dubroca <sd@...asysnail.net> wrote:

> diff --git a/drivers/net/ethernet/atheros/alx/hw.h b/drivers/net/ethernet/atheros/alx/hw.h
> index 207bcc6..97e8731 100644
> --- a/drivers/net/ethernet/atheros/alx/hw.h
> +++ b/drivers/net/ethernet/atheros/alx/hw.h
> @@ -482,6 +482,8 @@ struct alx_hw {
>  
>  	/* PHY link patch flag */
>  	bool lnk_patch;
> +
> +	struct alx_hw_stats stats;
>  };

Why do you need this to be part of the hw struct?
It doesn't need to be persistent.
couldn't the callers just pass it on the stack.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html