netdev - Re: [PATCH 4/5] alx: add alx_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140101.222702.1562824655053158808.davem@davemloft.net>
Date:	Wed, 01 Jan 2014 22:27:02 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	sd@...asysnail.net
Cc:	johannes@...solutions.net, netdev@...r.kernel.org
Subject: Re: [PATCH 4/5] alx: add alx_get_stats operation

From: Sabrina Dubroca <sd@...asysnail.net>
Date: Thu,  2 Jan 2014 00:40:27 +0100

> +	spin_lock(&alx->stats_lock);
> +
> +	__alx_update_hw_stats(&alx->hw);

Please use something like the linux/u64_stats_sync.h stuff rather
than spin locking.

Thank you.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html