netdev - Re: [PATCH net-next] ipv6: fix the use of pcpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1388634182.12212.82.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Wed, 01 Jan 2014 19:43:02 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	roy.qing.li@...il.com
Cc:	netdev@...r.kernel.org,
	Stephen Hemminger <stephen@...workplumber.org>
Subject: Re: [PATCH net-next] ipv6: fix the use of pcpu_tstats in sit

On Thu, 2014-01-02 at 08:49 +0800, roy.qing.li@...il.com wrote:
> From: Li RongQing <roy.qing.li@...il.com>
> 
> when read/write the 64bit data, the correct lock should be hold.
> 
> Signed-off-by: Li RongQing <roy.qing.li@...il.com>
> ---
>  net/ipv6/sit.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/net/ipv6/sit.c b/net/ipv6/sit.c
> index 366fbba..1e33d77 100644
> --- a/net/ipv6/sit.c
> +++ b/net/ipv6/sit.c
> @@ -702,8 +702,10 @@ static int ipip6_rcv(struct sk_buff *skb)
>  		}
>  
>  		tstats = this_cpu_ptr(tunnel->dev->tstats);
> +		u64_stats_update_begin(&tstats->syncp);
>  		tstats->rx_packets++;
>  		tstats->rx_bytes += skb->len;
> +		u64_stats_update_end(&tstats->syncp);
>  
>  		netif_rx(skb);
>  

Fixes: 87b6d218f3adb ("tunnel: implement 64 bits statistics")
Cc: Stephen Hemminger <stephen@...workplumber.org>
Acked-by: Eric Dumazet <edumazet@...gle.com>

Thats a candidate for net and stable trees.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html