netdev - Re: inconsistency of ethtool feature names for get vs. set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 2 Jan 2014 18:41:54 +0000
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Or Gerlitz <ogerlitz@...lanox.com>
CC:	netdev <netdev@...r.kernel.org>
Subject: Re: inconsistency of ethtool feature names for get vs. set

On Thu, 2014-01-02 at 15:03 +0000, Ben Hutchings wrote:
> On Thu, 2014-01-02 at 11:47 +0200, Or Gerlitz wrote:
[...]
> > $ ethtool -k eth1  | grep generic-receive-offload
> > generic-receive-offload: on
> > 
> > $ ethtool -K eth1  generic-receive-offload off
> > ethtool: bad command line argument(s)
> > For more information run ethtool -h
> > 
> > --> looking in the sources and realizing I need to use "rx-gro"
> 
> Or 'gro'.  All the old feature names that can be used with the -K option
> are listed in the manual page.  All the new feature names are consistent
> between -k/-K.

By 'new feature names' I mean names for features that weren't previously
exposed through ethtool.

[...]
> > Basically, this can be resolved by fairly simple patch, but I wasn't 
> > sure if you want it in user space, in the kernel or both...
> 
> How do you intend to resolve this, given the compatibility requirement
> that the old names must still be reported by -k and accepted by -K?

Just to be clear, I do see that there's a problem here but the fix may
have to be mostly or entirely in documentation rather than code.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html