netdev - Re: [net-next bugfix] tun, rfs: fix the incorrect hash value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52C4FC24.6060805@redhat.com>
Date:	Thu, 02 Jan 2014 13:41:56 +0800
From:	Jason Wang <jasowang@...hat.com>
To:	Zhi Yong Wu <zwu.kernel@...il.com>, netdev@...r.kernel.org
CC:	therbert@...gle.com, Zhi Yong Wu <wuzhy@...ux.vnet.ibm.com>
Subject: Re: [net-next bugfix] tun, rfs:  fix the incorrect hash value

On 01/02/2014 01:24 PM, Zhi Yong Wu wrote:
> From: Zhi Yong Wu <wuzhy@...ux.vnet.ibm.com>
>
> The code incorrectly save the queue index as the hash, so this patch
> is fixing it with the hash received in the stack receive path.
>
> Signed-off-by: Zhi Yong Wu <wuzhy@...ux.vnet.ibm.com>
> ---
>  drivers/net/tun.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/tun.c b/drivers/net/tun.c
> index 3cf0457..09f6662 100644
> --- a/drivers/net/tun.c
> +++ b/drivers/net/tun.c
> @@ -378,8 +378,8 @@ static u16 tun_select_queue(struct net_device *dev, struct sk_buff *skb)
>  	if (txq) {
>  		e = tun_flow_find(&tun->flows[tun_hashfn(txq)], txq);
>  		if (e) {
> -			txq = e->queue_index;
>  			tun_flow_save_rps_rxhash(e, txq);
> +			txq = e->queue_index;
>  		} else
>  			/* use multiply and shift instead of expensive divide */
>  			txq = ((u64)txq * numqueues) >> 32;

Acked-by: Jason Wang <jasowang@...hat.com>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html