netdev - Re: [Patch net-next] net: revert "sched classifier: make cgroup table local"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 03 Jan 2014 00:32:40 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	stephen@...workplumber.org
Cc:	xiyou.wangcong@...il.com, netdev@...r.kernel.org
Subject: Re: [Patch net-next] net: revert "sched classifier: make cgroup
 table local"

From: Stephen Hemminger <stephen@...workplumber.org>
Date: Thu, 2 Jan 2014 17:21:10 -0800

> On Thu, 02 Jan 2014 19:03:23 -0500 (EST)
> David Miller <davem@...emloft.net> wrote:
> 
>> From: Cong Wang <xiyou.wangcong@...il.com>
>> Date: Thu,  2 Jan 2014 14:58:41 -0800
>> 
>> > This reverts commit de6fb288b1246a5c4e00c0cdbfe3a838a360b3f4.
>> > Otherwise we got:
>> > 
>> > net/sched/cls_cgroup.c:106:29: error: static declaration of ‘net_cls_subsys’ follows non-static declaration
>> >  static struct cgroup_subsys net_cls_subsys = {
>> >                              ^
>> > In file included from include/linux/cgroup.h:654:0,
>> >                  from net/sched/cls_cgroup.c:18:
>> > include/linux/cgroup_subsys.h:35:29: note: previous declaration of ‘net_cls_subsys’ was here
>> >  SUBSYS(net_cls)
>> >                              ^
>> > make[2]: *** [net/sched/cls_cgroup.o] Error 1
>> > 
>> > Cc: Stephen Hemminger <stephen@...workplumber.org>
>> > Cc: David S. Miller <davem@...emloft.net>
>> > Signed-off-by: Cong Wang <xiyou.wangcong@...il.com>
>> 
>> This is so damn unintuitive, and that build error only occurs if you
>> build cls_cgroup statically.
>> 
>> Applied, but the way this works is terrible.
> 
> Just removing from the include file is probably enough to fix it.

It's being referenced via the "SUBSYS" macro, and that is how this
cgroup subsystem instantiated in the static build.

You can't just delete it.