netdev - Re: [RFC PATCH net-next 1/4] net: introduce backup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52C656F2.8060803@gmail.com>
Date:	Thu, 02 Jan 2014 22:21:38 -0800
From:	John Fastabend <john.fastabend@...il.com>
To:	clbchenlibo.chen@...wei.com
CC:	David Miller <davem@...emloft.net>, edumazet@...gle.com,
	jasowang@...hat.com, horms@...ge.net.au, serge.hallyn@...ntu.com,
	netdev@...r.kernel.org, cgroups@...r.kernel.org,
	containers@...ts.linux-foundation.org, kaber@...sh.net,
	xemul@...nvz.org, ebiederm@...ssion.com,
	linux-kernel@...r.kernel.org, jhs@...atatu.com, lizefan@...wei.com
Subject: Re: [RFC PATCH net-next 1/4] net: introduce backup_classid to struct
 skbuff

On 01/02/2014 09:34 PM, David Miller wrote:
> From: Libo Chen <clbchenlibo.chen@...wei.com>
> Date: Fri, 3 Jan 2014 11:11:04 +0800
>
>>
>> introduce backup_classid to struct skbuff,
>> we can use it to backup sk_classid when net_ns switch.
>>
>> Signed-off-by: Libo Chen <clbchenlibo.chen@...wei.com>
>
> Sorry, no new sk_buff members unless there is absolutely not other
> possible implementation.
>
> sk_buff is too big as-is.

To get what you want fix the dev_forward_skb() call. But its
not clear to me why you would expect the sock info to be propagated
like this. It seems like an incorrect assumption or a misunderstanding
somewhere. If the virtual link was a physical link you wouldn't expect
to know anything about the senders socket.

Thanks,
John

-- 
John Fastabend         Intel Corporation
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html