netdev - Re: [PATCH 5/5] bgmac: add support for Northstar SoC (BCM4707, BCM53018)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACna6rz-R0=L9ZhfV13R_9wvG0FMowmx_YYgdXYM7EaSkXDgmw@mail.gmail.com>
Date:	Fri, 3 Jan 2014 07:18:54 +0100
From:	Rafał Miłecki <zajec5@...il.com>
To:	Hauke Mehrtens <hauke@...ke-m.de>
Cc:	David Miller <davem@...emloft.net>,
	Network Development <netdev@...r.kernel.org>
Subject: Re: [PATCH 5/5] bgmac: add support for Northstar SoC (BCM4707, BCM53018)

2014/1/3 Rafał Miłecki <zajec5@...il.com>:
> 2014/1/2 Hauke Mehrtens <hauke@...ke-m.de>:
>> On 01/02/2014 09:40 PM, Rafał Miłecki wrote:
>>>  > +       if (ci->id == BCMA_CHIP_ID_BCM4707 ||
>>>> +           ci->id == BCMA_CHIP_ID_BCM53018) {
>>>
>>> Please add a missing
>>> if (bgmac->phyaddr != BGMAC_PHY_NOREGS)
>>> return;
>>> at the beginning of this 4707/53018 block
>>
>> Why should I add that there?
>
> This is what I can see in etcgmac.c version:
> * $Id: etcgmac.c 414031 2013-07-23 10:54:51Z $

Hm, this is weird. I think this
* $Id: etcgmac.c 414031 2013-07-23 10:54:51Z $
is not any version, but just a timestamp of executing some cleaning-script.

Anyway, your reference code is 6.37.14.62:
https://github.com/RMerl/asuswrt-merlin/blob/master/release/src-rt-6.x.4708/include/epivers.h

And mine is 6.37.14.34 (GPL_RT_AC68U_30004374205.zip).

So it seems your is newer one...

OK, leave this code like it is, ignore that my comment for now.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html