netdev - Re: [PATCH] ipv6: don't call addrconf_dst

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140103065349.GK22494@order.stressinduktion.org>
Date:	Fri, 3 Jan 2014 07:53:49 +0100
From:	Hannes Frederic Sowa <hannes@...essinduktion.org>
To:	chenweilong <chenweilong@...wei.com>
Cc:	David Miller <davem@...emloft.net>, gaofeng@...fujitsu.com,
	kumaran.4353@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH] ipv6: don't call addrconf_dst_alloc again when enable lo

On Thu, Jan 02, 2014 at 05:33:15PM +0800, chenweilong wrote:
> diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
> index 62d1799..d2f8c0a 100644
> --- a/net/ipv6/addrconf.c
> +++ b/net/ipv6/addrconf.c
> @@ -2422,8 +2422,9 @@ static void init_loopback(struct net_device *dev)
>  			if (sp_ifa->flags & (IFA_F_DADFAILED | IFA_F_TENTATIVE))
>  				continue;
> 
> -			if (sp_ifa->rt)
> -				continue;
> +			if (sp_ifa->rt && sp_ifa->rt->dst.dev == dev) {
> +				ip6_del_rt(sp_ifa->rt);
> +			}
> 
>  			sp_rt = addrconf_dst_alloc(idev, &sp_ifa->addr, 0);
> 

Maybe this change would not be that bad after all, as those ifa attached dsts
are already dead and queued up for gc and should not get inserted back.

I'll try to just disable routes without removing them at all when we set an
interface to down at the weekend.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html