netdev - Re: [RFC PATCH net-next 3/4] veth: backup classid befor switch net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 03 Jan 2014 14:45:19 +0400
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Libo Chen <clbchenlibo.chen@...wei.com>,
	David Miller <davem@...emloft.net>
CC:	edumazet@...gle.com, kaber@...sh.net, peterz@...radead.org,
	honkiko@...il.com, netdev@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>, cgroups@...r.kernel.org,
	containers@...ts.linux-foundation.org, jhs@...atatu.com,
	Li Zefan <lizefan@...wei.com>,
	Serge Hallyn <serge.hallyn@...ntu.com>
Subject: Re: [RFC PATCH net-next 3/4] veth: backup classid befor switch net_ns

Hello.

On 03-01-2014 7:11, Libo Chen wrote:

> dev_forward_skb will clear skb->sk, so we need save classid
> before that, otherwise the skb can not be under control by
> net_cls.

> Signed-off-by: Libo Chen <clbchenlibo.chen@...wei.com>
> ---
>   drivers/net/veth.c | 7 +++++++
>   1 file changed, 7 insertions(+)

> diff --git a/drivers/net/veth.c b/drivers/net/veth.c
> index 2ec2041..ce43a2d 100644
> --- a/drivers/net/veth.c
> +++ b/drivers/net/veth.c
[...]
> @@ -123,6 +124,12 @@ static netdev_tx_t veth_xmit(struct sk_buff *skb, struct net_device *dev)
>   	    rcv->features & NETIF_F_RXCSUM)
>   		skb->ip_summed = CHECKSUM_UNNECESSARY;
>
> +	/**

    Why you're using kernel-doc style comments out of place? The format of 
multi-line comments  in the networking code is this:

/* bla
  * bla
  */

> +	 * dev_forward_sbk will clear skb->sk, so save
> +	 * skb->sk->sk_classid for Qos
> +	 */
> +	bk_cls_classid(skb);
> +

WBR, Sergei


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html