netdev - Re: [PATCH 0/2 v3] ipv4: Cache dst in tunnels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 03 Jan 2014 19:42:33 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	therbert@...gle.com
Cc:	netdev@...r.kernel.org, eric.dumazet@...il.com
Subject: Re: [PATCH 0/2 v3] ipv4: Cache dst in tunnels

From: Tom Herbert <therbert@...gle.com>
Date: Thu, 2 Jan 2014 11:48:18 -0800 (PST)

> Version 3 of caching routes in tunnels.

Applied, but I really have to wonder when I have to fix up things like
this:

net/ipv4/ip_tunnel.c: In function ‘ip_tunnel_init’:
net/ipv4/ip_tunnel.c:1062:20: warning: assignment from incompatible pointer type [enabled by default]

-->

--- a/net/ipv4/ip_tunnel.c
+++ b/net/ipv4/ip_tunnel.c
@@ -1059,7 +1059,7 @@ int ip_tunnel_init(struct net_device *dev)
 		u64_stats_init(&ipt_stats->syncp);
 	}
 
-	tunnel->dst_cache = alloc_percpu(struct ip_tunnel_dst *);
+	tunnel->dst_cache = alloc_percpu(struct ip_tunnel_dst);
 	if (!tunnel->dst_cache) {
 		free_percpu(dev->tstats);
 		return -ENOMEM;