netdev - Re: [PATCH net-next] net-gre-gro: Add GRE support to the GRO stack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1388885588.12212.158.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Sat, 04 Jan 2014 17:33:08 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	hkchu@...gle.com, edumazet@...gle.com, herbert@...dor.apana.org.au,
	ogerlitz@...lanox.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net-gre-gro: Add GRE support to the GRO stack

On Sat, 2014-01-04 at 20:09 -0500, David Miller wrote:
> From: "H.K. Jerry Chu" <hkchu@...gle.com>
> Date: Fri,  3 Jan 2014 21:24:07 -0800
> 
> > +struct packet_offload *gro_find_receive_by_type(__be16 type);
> > +struct packet_offload *gro_find_complete_by_type(__be16 type);
> 
> You're not exporting these to modules, therefore if GRE is built
> modular it won't work.


Ah, I see now net/ipv4/gre_offload.c is not statically included.

This is unfortunate, as GRO/GSO should be fully enabled on routers, even
if no GRE tunnel is setup on the host.

Whole point of moving this stuff in separate gre_offload.c (commit
c50cd357887ac "net: gre: move GSO functions to gre_offload") was offer
offload capabilities without having to load GRE module.

diff --git a/net/ipv4/Makefile b/net/ipv4/Makefile
index 4b81e91c80fe..f8c49ce5b283 100644
--- a/net/ipv4/Makefile
+++ b/net/ipv4/Makefile
@@ -11,7 +11,7 @@ obj-y     := route.o inetpeer.o protocol.o \
 	     tcp_offload.o datagram.o raw.o udp.o udplite.o \
 	     udp_offload.o arp.o icmp.o devinet.o af_inet.o igmp.o \
 	     fib_frontend.o fib_semantics.o fib_trie.o \
-	     inet_fragment.o ping.o ip_tunnel_core.o
+	     inet_fragment.o ping.o ip_tunnel_core.o gre_offload.o
 
 obj-$(CONFIG_NET_IP_TUNNEL) += ip_tunnel.o
 obj-$(CONFIG_SYSCTL) += sysctl_net_ipv4.o
@@ -19,7 +19,7 @@ obj-$(CONFIG_PROC_FS) += proc.o
 obj-$(CONFIG_IP_MULTIPLE_TABLES) += fib_rules.o
 obj-$(CONFIG_IP_MROUTE) += ipmr.o
 obj-$(CONFIG_NET_IPIP) += ipip.o
-gre-y := gre_demux.o gre_offload.o
+gre-y := gre_demux.o
 obj-$(CONFIG_NET_IPGRE_DEMUX) += gre.o
 obj-$(CONFIG_NET_IPGRE) += ip_gre.o
 obj-$(CONFIG_NET_IPVTI) += ip_vti.o


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html