netdev - Re: [PATCH net-next] net-gre-gro: Add GRE support to the GRO stack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPshTCi0KEAysZZcstj7eFcoGTG5aSH=KrNNMb0BhdqfxF7qMw@mail.gmail.com>
Date:	Sun, 5 Jan 2014 12:00:39 +0800
From:	Jerry Chu <hkchu@...gle.com>
To:	David Miller <davem@...emloft.net>
Cc:	Eric Dumazet <edumazet@...gle.com>,
	Herbert Xu <herbert@...dor.apana.org.au>,
	Or Gerlitz <ogerlitz@...lanox.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] net-gre-gro: Add GRE support to the GRO stack

On Sun, Jan 5, 2014 at 9:09 AM, David Miller <davem@...emloft.net> wrote:
> From: "H.K. Jerry Chu" <hkchu@...gle.com>
> Date: Fri,  3 Jan 2014 21:24:07 -0800
>
>> +struct packet_offload *gro_find_receive_by_type(__be16 type);
>> +struct packet_offload *gro_find_complete_by_type(__be16 type);
>
> You're not exporting these to modules, therefore if GRE is built
> modular it won't work.
>
> Please use GPL exports.

Aha, now I remember why i decided to export the symbols, the same
reason above. Also I thought in the future other encap protocol that is
not statically included might need to access the symbols.

But given Eric's point below these other encap protocol could always
place their GRO handler in separate files to be included statically. So
I'll include Eric's change below. Hope it makes sense.

Thanks,

Jerry
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html