lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Sun, 05 Jan 2014 10:57:24 -0800
From:	Guenter Roeck <linux@...ck-us.net>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
CC:	Karsten Keil <isdn@...ux-pingi.de>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	linux-kbuild <linux-kbuild@...r.kernel.org>
Subject: Re: [PATCH] isdn: Build telespci and hfc_pci only for little endian
 CPUs

On 01/05/2014 10:30 AM, Geert Uytterhoeven wrote:
> On Sun, Jan 5, 2014 at 6:50 PM, Guenter Roeck <linux@...ck-us.net> wrote:
>> -       depends on PCI && (BROKEN || !(SPARC || PPC || PARISC || M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA && !CPU_LITTLE_ENDIAN)))
>> +       depends on CPU_LITTLE_ENDIAN && PCI && (BROKEN || !(SPARC || PPC || PARISC || M68K || MIPS || FRV || XTENSA))
>
> Unfortunately CPU_LITTLE_ENDIAN is only available on architectures
> that support two endiannesses. So the above will preclude e.g. x86, which is
> where most ISDN users are.
>
> One solution is to move CPU_LITTLE_ENDIAN and CPU_BIG_ENDIAN to the
> common Kconfig parts. After that, the dependency above can just become
>
>      depends on CPU_LITTLE_ENDIAN && PCI.
>

Excellent idea, but more invasive than I want to get into. I'll mark the build for the drivers
as broken for big endian ARM machines instead. The cleanup you suggested can then go in as
separate patch (if wanted).

Thanks,
Guenter

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists