netdev - Re: Multicast routing stops functioning after 4G multicast packets recived.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1388949137.12212.166.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Sun, 05 Jan 2014 11:12:17 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Hannes Frederic Sowa <hannes@...essinduktion.org>
Cc:	Julian Anastasov <ja@....bg>,
	Bob Falken <NetFestivalHaveFun@....com>, netdev@...r.kernel.org
Subject: Re: Multicast routing stops functioning after 4G multicast packets
 recived.

On Sun, 2014-01-05 at 11:41 +0100, Hannes Frederic Sowa wrote:
> On Sun, Jan 05, 2014 at 10:56:55AM +0200, Julian Anastasov wrote:
> > 
> > 	Hello,
> > 
> > On Sun, 5 Jan 2014, Hannes Frederic Sowa wrote:
> > 
> > > I guess we should just try. I somehow forgot to look after that. Thanks
> > > for reminding, Julian.
> > 
> > 	If that patch solves the problem, do not forget
> > to include same fix for ip6mr_fib_lookup(). As for net/decnet/,
> > it looks ok, it uses fib_rule_put() in dn_fib_res_put().
> 
> Thanks, I had IPv6 on my radar but did not check for other callers.

BTW, I wonder if the old kernels (2.6.32 & 2.6.34) need something as
well ?

Before commit ebc0ffae5dfb444 and commit 7fa7cb7109d0, it looks like we
had an overflow in fib_rule_get() and refcnt was wrapping.

So maybe we should add a fib_rule_put() for stable kernels, and use
FIB_LOOKUP_NOREF on next kernels ...



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html