netdev - Re: [PATCH net-next] net/mlx4_core: Warn if device doesn't have enough PCI bandwidth

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1389042955.9947.110.camel@bwh-desktop.uk.level5networks.com>
Date:	Mon, 6 Jan 2014 21:15:55 +0000
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Amir Vadai <amirv@...lanox.com>,
	Jeff Kirsher <jeffrey.t.kirsher@...el.com>,
	Bjorn Helgaas <bhelgaas@...gle.com>
CC:	"David S. Miller" <davem@...emloft.net>, <netdev@...r.kernel.org>,
	"Or Gerlitz" <ogerlitz@...lanox.com>,
	Eyal Perry <eyalpe@...lanox.com>
Subject: Re: [PATCH net-next] net/mlx4_core: Warn if device doesn't have
 enough PCI bandwidth

On Sat, 2014-01-04 at 21:17 +0200, Amir Vadai wrote:
> From: Eyal Perry <eyalpe@...lanox.com>
> 
> Check if the device get enough bandwidth from the entire PCI chain to satisfy
> its capabilities. This patch determines the PCIe device's bandwidth capabilities
> by reading its PCIe Link Capabilities registers and then call the
> pcie_get_minimum_link function to ensure that the adapter is hooked into a slot
> which is capable of providing the necessary bandwidth capabilities.
[...]

This is essentially another duplicate of what ixgbe and i40e are
doing...  (And the out-of-tree version of sfc does it too, but I never
felt that was ready for in-tree.)

We ought to have a generic PCI layer function that warns when a PCIe
device is running below maximum link width/speed.  Maybe even run it as
soon as the device is enumerated, so that a driver doesn't need to do
anything.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html