netdev - Re: question about ixgbevf/ixgbevf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.10.1401071643340.2094@hadrien>
Date:	Tue, 7 Jan 2014 16:44:53 +0100 (CET)
From:	Julia Lawall <julia.lawall@...6.fr>
To:	Alexander Duyck <alexander.h.duyck@...el.com>
cc:	Julia Lawall <julia.lawall@...6.fr>, donald.c.skidmore@...el.com,
	e1000-devel@...ts.sourceforge.net, netdev@...r.kernel.org
Subject: Re: question about ixgbevf/ixgbevf_main.c

On Tue, 7 Jan 2014, Alexander Duyck wrote:

> A VF isn't a real device so it shouldn't really have the concept of a
> power state.  The power state for the device is controlled via the PF.
> I suspect the fact that ixgbevf is modifying power state on resume is
> likely a bug.

Thanks for the information, which is very helpful.  Should I submit a
patch to remove it in the resume function?  I don't have the ability ot
test it, though.

julia

>
> Thanks,
>
> Alex
>
> On 01/07/2014 06:46 AM, Julia Lawall wrote:
> > I was wondering why ixgbevf_suspend doesn't call pci_set_power_state?  It
> > is called in the corresponding resume function, and most other PCI drivers
> > with a suspend functyion also call it in suspend.
> >
> > thanks,
> > julia
> > --
> > To unsubscribe from this list: send the line "unsubscribe netdev" in
> > the body of a message to majordomo@...r.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> >
>
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html