netdev - Re: question about ixgbevf/ixgbevf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 07 Jan 2014 07:55:15 -0800
From:	Alexander Duyck <alexander.h.duyck@...el.com>
To:	Julia Lawall <julia.lawall@...6.fr>
CC:	donald.c.skidmore@...el.com, e1000-devel@...ts.sourceforge.net,
	netdev@...r.kernel.org
Subject: Re: question about ixgbevf/ixgbevf_main.c

On 01/07/2014 07:44 AM, Julia Lawall wrote:
> On Tue, 7 Jan 2014, Alexander Duyck wrote:
>
>> A VF isn't a real device so it shouldn't really have the concept of a
>> power state.  The power state for the device is controlled via the PF.
>> I suspect the fact that ixgbevf is modifying power state on resume is
>> likely a bug.
> Thanks for the information, which is very helpful.  Should I submit a
> patch to remove it in the resume function?  I don't have the ability ot
> test it, though.
>
> julia
>

You could submit a patch.  The issue should just be cosmetic.  Setting
the power state to D0 should have no impact on things one way or another
since that is the state VFs are normally in when they are created.

Thanks,

Alex
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html