[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20140109.165614.996208898326487313.davem@davemloft.net>
Date: Thu, 09 Jan 2014 16:56:14 -0500 (EST)
From: David Miller <davem@...emloft.net>
To: bhutchings@...arflare.com
Cc: gregory.v.rose@...el.com, sergei.shtylyov@...entembedded.com,
jeffrey.t.kirsher@...el.com, netdev@...r.kernel.org,
gospo@...hat.com, sassmann@...hat.com, mitch.a.williams@...el.com,
jesse.brandeburg@...el.com
Subject: Re: [net-next 05/15] i40e: add a comment on barrier and fix panic
on reset
From: Ben Hutchings <bhutchings@...arflare.com>
Date: Thu, 9 Jan 2014 21:23:10 +0000
> On Thu, 2014-01-09 at 21:21 +0000, Ben Hutchings wrote:
>> On Thu, 2014-01-09 at 15:12 -0500, David Miller wrote:
>> > From: Greg Rose <gregory.v.rose@...el.com>
>> > Date: Thu, 9 Jan 2014 09:17:35 -0800
>> >
>> > > Yes, it's apparent that two different internal patches were compressed
>> > > together. If its unacceptable to do this then I'll speak to Jeff about
>> > > splitting them.
>> >
>> > I won't reject the entire pull request on account of this, but please
>> > don't do this in the future.
>>
>> I don't understand this. You don't want to see patches that are known
>> to introduce regressions, and you expect people to squash together known
>> buggy patches with their subsequent fix-ups before submitting.
> [...]
>
> Hmm, looking at this again, I suppose it is just this particular
> combination of two unrelated changes you're objecting to?
Yes.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists