netdev - Re: [PATCH net,stable] net: usbnet: fix SG initialisation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACVXFVOxZVhLJMUZt9Bwsq=QwcFuDxKpJki5F2JH59iyZ=3uFw@mail.gmail.com>
Date:	Sun, 12 Jan 2014 00:22:09 +0800
From:	Ming Lei <ming.lei@...onical.com>
To:	Bjørn Mork <bjorn@...k.no>
Cc:	Network Development <netdev@...r.kernel.org>,
	linux-usb <linux-usb@...r.kernel.org>,
	Thomas Kear <thomas@...r.co.nz>,
	Ben Hutchings <bhutchings@...arflare.com>
Subject: Re: [PATCH net,stable] net: usbnet: fix SG initialisation

On Sat, Jan 11, 2014 at 5:16 PM, Ming Lei <ming.lei@...onical.com> wrote:
> On Sat, Jan 11, 2014 at 6:10 AM, Bjørn Mork <bjorn@...k.no> wrote:
>> Commit 60e453a940ac ("USBNET: fix handling padding packet")
>> added an extra SG entry in case padding is necessary, but
>> failed to update the initialisation of the list. This can
>> cause list traversal to fall off the end of the list,
>> resulting in an oops.
>>
>> Fixes: 60e453a940ac ("USBNET: fix handling padding packet")
>> Reported-by: Thomas Kear <thomas@...r.co.nz>
>> Cc: Ming Lei <ming.lei@...onical.com>
>> Signed-off-by: Bjørn Mork <bjorn@...k.no>

Tested-by: Ming Lei <ming.lei@...onical.com>

On one of my arm box, I can reproduce the problem with below
command every time:

                   $iperf -c $SRV -l 2398 -n 1 #the 2nd tcp packet
length is 1016

and the oops is same with Thomas's. After applying Oliver's patch,
I still can see zlp padding packet is appended, but no oops any more.

Thanks Oliver for fixing the problem.

Thanks,
--
Ming Lei
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html