lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 11 Jan 2014 09:52:37 -0800 From: Joe Perches <joe@...ches.com> To: Aruna-Hewapathirane <aruna.hewapathirane@...il.com> Cc: netdev@...r.kernel.org, hannes@...essinduktion.org Subject: Re: [PATCH net-next] net: replace macros net_random and net_srandom with direct calls to prandom On Sat, 2014-01-11 at 07:15 -0500, Aruna-Hewapathirane wrote: > This patch removes the net_random and net_srandom macros and replaces > them with direct calls to the prandom ones. As new commits only seem to > use prandom_u32 there is no use to keep them around. > This change makes it easier to grep for users of prandom_u32. Seems sensible. Also, there may be some value in a future patch to use reciprocal_divide in a few places > diff --git a/net/802/garp.c b/net/802/garp.c > @@ -397,7 +397,7 @@ static void garp_join_timer_arm(struct garp_applicant *app) > { > unsigned long delay; > > - delay = (u64)msecs_to_jiffies(garp_join_time) * net_random() >> 32; > + delay = (u64)msecs_to_jiffies(garp_join_time) * prandom_u32() >> 32; reciprocal_divide() > diff --git a/net/802/mrp.c b/net/802/mrp.c [] > @@ -583,7 +583,7 @@ static void mrp_join_timer_arm(struct mrp_applicant *app) > { > unsigned long delay; > > - delay = (u64)msecs_to_jiffies(mrp_join_time) * net_random() >> 32; > + delay = (u64)msecs_to_jiffies(mrp_join_time) * prandom_u32() >> 32; here too > diff --git a/net/ipv4/udp.c b/net/ipv4/udp.c [] > @@ -223,7 +223,7 @@ int udp_lib_get_port(struct sock *sk, unsigned short snum, > inet_get_local_port_range(net, &low, &high); > remaining = (high - low) + 1; > > - rand = net_random(); > + rand = prandom_u32(); > first = (((u64)rand * remaining) >> 32) + low; another -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists