netdev - Re: [PATCH net-next] net: replace macros net_random and net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1389465789.2537.66.camel@joe-AO722>
Date:	Sat, 11 Jan 2014 10:43:09 -0800
From:	Joe Perches <joe@...ches.com>
To:	Hannes Frederic Sowa <hannes@...essinduktion.org>
Cc:	Aruna-Hewapathirane <aruna.hewapathirane@...il.com>,
	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: replace macros net_random and net_srandom
 with direct calls to prandom

On Sat, 2014-01-11 at 19:00 +0100, Hannes Frederic Sowa wrote:
> On Sat, Jan 11, 2014 at 09:52:37AM -0800, Joe Perches wrote:
> > On Sat, 2014-01-11 at 07:15 -0500, Aruna-Hewapathirane wrote:
> > > This patch removes the net_random and net_srandom macros and replaces
> > > them with direct calls to the prandom ones. As new commits only seem to
> > > use prandom_u32 there is no use to keep them around.
> > > This change makes it easier to grep for users of prandom_u32.
> > 
> > Seems sensible.
> > 
> > Also, there may be some value in a future patch
> > to use reciprocal_divide in a few places
> > 
> > > diff --git a/net/802/garp.c b/net/802/garp.c
> > > @@ -397,7 +397,7 @@ static void garp_join_timer_arm(struct garp_applicant *app)
> > >  {
> > >  	unsigned long delay;
> > >  
> > > -	delay = (u64)msecs_to_jiffies(garp_join_time) * net_random() >> 32;
> > > +	delay = (u64)msecs_to_jiffies(garp_join_time) * prandom_u32() >> 32;
> > 
> > reciprocal_divide()
> 
> Does reciprocal_divide() make sense without reciprocal_value() from a
> stylish point of view?

Hi again.

Dunno.

I think there's some value in the name triggering
reader recognition of what the code is doing.

> I wouldn't do that just because it expands into the same code.

There are a few places where reciprocal_device is
used today without using reciprocal_value()


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html