netdev - Re: [PATCH net-next 06/10] vxlan: use __dev_get_by_index instead of dev_get_by

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140114085105.706779c1@nehalam.linuxnetplumber.net>
Date:	Tue, 14 Jan 2014 08:51:05 -0800
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Ying Xue <ying.xue@...driver.com>
Cc:	<davem@...emloft.net>, <vfalico@...hat.com>,
	<john.r.fastabend@...el.com>, <antonio@...hcoding.com>,
	<dmitry.tarnyagin@...kless.no>, <socketcan@...tkopp.net>,
	<johannes@...solutions.net>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next 06/10] vxlan: use __dev_get_by_index instead of
 dev_get_by_index to find interface

On Tue, 14 Jan 2014 15:41:05 +0800
Ying Xue <ying.xue@...driver.com> wrote:

> The following call chains indicate that vxlan_fdb_parse() is
> under rtnl_lock protection. So if we use __dev_get_by_index()
> instead of dev_get_by_index() to find interface handler in it,
> this would help us avoid to change interface reference counter.
> 
> rtnetlink_rcv()
>   rtnl_lock()
>   netlink_rcv_skb()
>     rtnl_fdb_add()
>       vxlan_fdb_add()
>         vxlan_fdb_parse()
>   rtnl_unlock()
> 
> rtnetlink_rcv()
>   rtnl_lock()
>   netlink_rcv_skb()
>     rtnl_fdb_del()
>       vxlan_fdb_del()
>         vxlan_fdb_parse()
>   rtnl_unlock()
> 
> Cc: Stephen Hemminger <stephen@...workplumber.org>
> Signed-off-by: Ying Xue <ying.xue@...driver.com>

Acked-by: Stephen Hemminger <stephen@...workplumber.org>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html