netdev - Re: [PATCH] e1000e: Fix compilation warning when !CONFIG_PM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140116.153650.1123366219148240100.davem@davemloft.net>
Date:	Thu, 16 Jan 2014 15:36:50 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	mika.westerberg@...ux.intel.com
Cc:	davidx.m.ertman@...el.com, aaron.f.brown@...el.com,
	jeffrey.t.kirsher@...el.com, bruce.w.allan@...el.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH] e1000e: Fix compilation warning when !CONFIG_PM_SLEEP

From: Mika Westerberg <mika.westerberg@...ux.intel.com>
Date: Thu, 16 Jan 2014 14:39:39 +0200

> Commit 7509963c703b (e1000e: Fix a compile flag mis-match for
> suspend/resume) moved suspend and resume hooks to be available when
> CONFIG_PM is set. However, it can be set even if CONFIG_PM_SLEEP is not set
> causing following warnings to be emitted:
> 
> drivers/net/ethernet/intel/e1000e/netdev.c:6178:12: warning:
>   	‘e1000_suspend’ defined but not used [-Wunused-function]
> 
> drivers/net/ethernet/intel/e1000e/netdev.c:6185:12: warning:
> 	‘e1000_resume’ defined but not used [-Wunused-function]
> 
> To fix this make the hooks to be available only when CONFIG_PM_SLEEP is set
> and remove CONFIG_PM wrapping from driver ops because this is already
> handled by SET_SYSTEM_SLEEP_PM_OPS() and SET_RUNTIME_PM_OPS().
> 
> Signed-off-by: Mika Westerberg <mika.westerberg@...ux.intel.com>

Applied, thanks.