netdev - Re: [PATCH net-next 0/2] sctp: some small clean ups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140120122055.GA22690@hmsreliant.think-freely.org>
Date:	Mon, 20 Jan 2014 07:20:55 -0500
From:	Neil Horman <nhorman@...driver.com>
To:	Daniel Borkmann <dborkman@...hat.com>
Cc:	Wang Weidong <wangweidong1@...wei.com>, davem@...emloft.net,
	vyasevich@...il.com, netdev@...r.kernel.org,
	linux-sctp@...r.kernel.org
Subject: Re: [PATCH net-next 0/2] sctp: some small clean ups

On Mon, Jan 20, 2014 at 12:37:06PM +0100, Daniel Borkmann wrote:
> On 01/20/2014 12:27 PM, Wang Weidong wrote:
> >We have the macros in sctp.h, so use them for coding accordance
> >in sctp.
> 
> Thanks for doing this Wang.
> 
> I am actually wondering why we have these macro locking wrappers
> and not use these functions directly? Hm, any reasons? Maybe we
> should rather go in the other direction with this?
> 
Its because in the origional implementation of the sctp protocol, there was a
user space test harness which built the kernel module for userspace execution to
cary our some unit testing on the code.  It did so by redefining some of those
locking macros to user space friendly code.  IIRC we haven't use those unit
tests in years, and so should be removing them, not adding them to other
locations.

Neil

> >Wang Weidong (2):
> >   sctp: use sctp_local_bh_{disable|enable} instead
> >     local_bh_{disable|enable}
> >   sctp: use sctp_read_[un]lock instead of read_[un]lock
> >
> >  net/sctp/endpointola.c   |  4 ++--
> >  net/sctp/input.c         | 10 +++++-----
> >  net/sctp/proc.c          | 12 ++++++------
> >  net/sctp/sm_make_chunk.c |  8 ++++----
> >  net/sctp/socket.c        |  8 ++++----
> >  5 files changed, 21 insertions(+), 21 deletions(-)
> >
> 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html