netdev - [PATCH] net/openvswitch: Remove the skb encapsulation mark after decapsulation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1390403705-28690-1-git-send-email-ogerlitz@mellanox.com>
Date:	Wed, 22 Jan 2014 17:15:05 +0200
From:	Or Gerlitz <ogerlitz@...lanox.com>
To:	davem@...emloft.net
Cc:	netdev@...r.kernel.org, Or Gerlitz <ogerlitz@...lanox.com>,
	Joseph Gasparakis <joseph.gasparakis@...el.com>,
	Pravin B Shelar <pshelar@...ira.com>
Subject: [PATCH] net/openvswitch: Remove the skb encapsulation mark after decapsulation

We must unset the skb encapsulation mark before injecting the
decapsulated packet into ovs for the rest of its journey.

This follows the practice set by 0afb166 "vxlan: Add capability of Rx
checksum offload for inner packet" and the overall idea behind the
skb encapsulation field.

Cc: Joseph Gasparakis <joseph.gasparakis@...el.com>
Cc: Pravin B Shelar <pshelar@...ira.com>
Signed-off-by: Or Gerlitz <ogerlitz@...lanox.com>
---
 net/openvswitch/vport-vxlan.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/net/openvswitch/vport-vxlan.c b/net/openvswitch/vport-vxlan.c
index e797a50..3742c71 100644
--- a/net/openvswitch/vport-vxlan.c
+++ b/net/openvswitch/vport-vxlan.c
@@ -68,6 +68,9 @@ static void vxlan_rcv(struct vxlan_sock *vs, struct sk_buff *skb, __be32 vx_vni)
 	key = cpu_to_be64(ntohl(vx_vni) >> 8);
 	ovs_flow_tun_key_init(&tun_key, iph, key, TUNNEL_KEY);
 
+	/* we must unset the encapsulation mark after decapsulation */
+	skb->encapsulation = 0;
+
 	ovs_vport_receive(vport, skb, &tun_key);
 }
 
-- 
1.7.1

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html