netdev - Re: [patch net-next 6/6] rtnetlink: remove IFLA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140123213345.GA2764@minipsycho.orion>
Date:	Thu, 23 Jan 2014 22:33:45 +0100
From:	Jiri Pirko <jiri@...nulli.us>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, fubar@...ibm.com, vfalico@...hat.com,
	andy@...yhouse.net, sfeldma@...ulusnetworks.com,
	stephen@...workplumber.org, vyasevic@...hat.com,
	nicolas.dichtel@...nd.com, john.r.fastabend@...el.com
Subject: Re: [patch net-next 6/6] rtnetlink: remove IFLA_SLAVES definition

Thu, Jan 23, 2014 at 09:47:16PM CET, davem@...emloft.net wrote:
>From: Jiri Pirko <jiri@...nulli.us>
>Date: Wed, 22 Jan 2014 11:43:55 +0100
>
>> Not used anymore, and never should be.
>> 
>> Signed-off-by: Jiri Pirko <jiri@...nulli.us>
>
>First of all your Subject doesn't match the patch, the subject mentions
>IFLA_SLAVES whereas the patch deletes IFLA_BOND_SLAVE.

Yep, sorry, IFLA_SLAVE was the original name, which I removed. Should I
repost?

>
>Secondly, you can't remove this, otherwise the next IFLA_* value added
>here will reuse that old number potentially breaking userland apps.

This has been in net-next tree for 3 days. It was a mistake, I think
there is very legit to remove this now, isn't it?

>
>I'm not applying this, sorry.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html