lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 27 Jan 2014 10:10:25 -0500 From: Josh Boyer <jwboyer@...oraproject.org> To: Sujith Manoharan <sujith@...jith.org> Cc: "John W. Linville" <linville@...driver.com>, ath9k-devel@...ema.h4ckr.net, netdev <netdev@...r.kernel.org>, "Linux-Kernel@...r. Kernel. Org" <linux-kernel@...r.kernel.org> Subject: Re: ath9k ARM build error with v3.13-8330-g4ba9920 On Sun, Jan 26, 2014 at 8:50 PM, Sujith Manoharan <sujith@...jith.org> wrote: > Josh Boyer wrote: >> adds a udelay(10000) call to the ath9k driver. This will cause a >> build error on various ARM configs because the value passed to udelay >> is too large: >> >> ERROR: "__bad_udelay" [drivers/net/wireless/ath/ath9k/ath9k_hw.ko] undefined! >> make[1]: *** [__modpost] Error 1 >> make: *** [modules] Error 2 >> >> Is the 10000 microsecond udelay really required? I believe the limit >> on ARM is 2000. Perhaps something else could be done in this case? > > The delay is a workaround for a HW issue. Does this patch fix the problem ? It fixes the build error, yes. I don't have actual HW to test, but the driver compiles on ARM now with the same config as before. Thanks! josh > > diff --git a/drivers/net/wireless/ath/ath9k/hw.c b/drivers/net/wireless/ath/ath9k/hw.c > index fbf43c0..11eab9f 100644 > --- a/drivers/net/wireless/ath/ath9k/hw.c > +++ b/drivers/net/wireless/ath/ath9k/hw.c > @@ -1316,7 +1316,7 @@ static bool ath9k_hw_set_reset(struct ath_hw *ah, int type) > if (AR_SREV_9300_20_OR_LATER(ah)) > udelay(50); > else if (AR_SREV_9100(ah)) > - udelay(10000); > + mdelay(10); > else > udelay(100); > > @@ -2051,9 +2051,8 @@ static bool ath9k_hw_set_power_awake(struct ath_hw *ah) > > REG_SET_BIT(ah, AR_RTC_FORCE_WAKE, > AR_RTC_FORCE_WAKE_EN); > - > if (AR_SREV_9100(ah)) > - udelay(10000); > + mdelay(10); > else > udelay(50); > > > Sujith -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists