netdev - Re: [PATCH ethtool] ethtool: Accept long feature names reported by -k option as input to -K option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1390786420.2735.108.camel@deadeye.wl.decadent.org.uk>
Date:	Mon, 27 Jan 2014 01:33:40 +0000
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Or Gerlitz <or.gerlitz@...il.com>
Cc:	Bill Fink <billfink@...dspring.com>, netdev@...r.kernel.org
Subject: Re: [PATCH ethtool] ethtool: Accept long feature names reported by
 -k option as input to -K option

On Wed, 2014-01-08 at 21:52 +0000, Ben Hutchings wrote:
> Before the generic features API was introduced, the ethtool -K option
> took short names for various features, e.g. 'gso' but the -k option
> reported their state using longer names,
> e.g. 'generic-segmentation-offload'.
> 
> All newer features have a single kernel-provided name so input
> and output are consistent.  But the old features still aren't, and
> although their short names are documented it's not good to have
> these exceptions.
> 
> Change the argument parsing code for -K so that the long names
> reported by -k are also accepted.
> 
> Reported-by: Or Gerlitz <or.gerlitz@...il.com>
> Signed-off-by: Ben Hutchings <bhutchings@...arflare.com>
> ---
> This turned out to be pretty easy to do as the argument processing is
> all table-driven already.  I'll push this if it works for you.
[...]

Can you confirm whether this does what you wanted?

Ben.

-- 
Ben Hutchings
If at first you don't succeed, you're doing about average.

Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)