lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 4 Feb 2014 02:58:11 +0400 From: Max Filippov <jcmvbkbc@...il.com> To: Florian Fainelli <f.fainelli@...il.com> Cc: netdev <netdev@...r.kernel.org>, "David S. Miller" <davem@...emloft.net> Subject: Re: [PATCH net] net: phy: ensure Gigabit features are masked off if requested On Tue, Feb 4, 2014 at 12:35 AM, Florian Fainelli <f.fainelli@...il.com> wrote: > When a Gigabit PHY device is connected to a 10/100Mbits capable Ethernet > MAC, the driver will restrict the phydev->supported modes to mask off > Gigabit. If the Gigabit PHY comes out of reset with the Gigabit features > set by default in MII_CTRL1000, it will keep advertising these feature, > so by the time we call genphy_config_advert(), the condition on > phydev->supported having the Gigabit features on is false, and we do not > update MII_CTRL1000 with updated values, and we keep advertising Gigabit > features, eventually configuring the PHY for Gigabit whilst the Ethernet > MAC does not support that. > > This patches fixes the problem by ensuring that the Gigabit feature bits > are always cleared in MII_CTRL1000, if the PHY happens to be a Gigabit > PHY, and then, if Gigabit features are supported, setting those and > updating MII_CTRL1000 accordingly. > > Reported-by: Max Filippov <jcmvbkbc@...il.com> > Signed-off-by: Florian Fainelli <f.fainelli@...il.com> > --- > drivers/net/phy/phy_device.c | 38 ++++++++++++++++++++++++-------------- > 1 file changed, 24 insertions(+), 14 deletions(-) Tested-by: Max Filippov <jcmvbkbc@...il.com> -- Thanks. -- Max -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists