lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 04 Feb 2014 12:00:31 -0800 From: Jay Vosburgh <fubar@...ibm.com> To: Ding Tianhong <dingtianhong@...wei.com> cc: Veaceslav Falico <vfalico@...hat.com>, "David S. Miller" <davem@...emloft.net>, Netdev <netdev@...r.kernel.org>, Andy Gospodarek <andy@...yhouse.net> Subject: Re: [PATCH RESEND net-next v3 0/2] bonding: Fix some issues for fail_over_mac Ding Tianhong <dingtianhong@...wei.com> wrote: >The parameter fail_over_mac only affect active-backup mode, if it was >set to active or follow and works with other modes, just like RR or XOR >mode, the bonding could not set all slaves to the master's address, it >will cause the slave could not work well with master. > >v1->v2: According Jay's suggestion, that we should permit setting an option > at any time, but only have it take effect in active-backup mode, so > I add mode checking together with fail_over_mac during enslavement and > rebuild the patches. > >v2->v3: The correct way to fix the problem is that we should not add restrictions when > setting options, just need to modify the bond enslave and removal processing > to check the mode in addition to fail_over_mac when setting a slave's MAC during > enslavement. The change active slave processing already only calls the fail_over_mac > function when in active-backup mode. > > Remove the cleanup patch because the net-next is frozen now. > >Regards >Ding Both patches look good to me. Signed-off-by: Jay Vosburgh <fubar@...ibm.com> -J --- -Jay Vosburgh, IBM Linux Technology Center, fubar@...ibm.com -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists