netdev - Re: [bisected] Re: WARNING: at net/ipv4/devinet.c:1599

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdWrYj1te-7qhKg-uHmXpuLaBBdqCEmpv_fgYSmaN3yujw@mail.gmail.com>
Date:	Tue, 4 Feb 2014 21:03:24 +0100
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Cong Wang <cwang@...pensource.com>
Cc:	"David S. Miller" <davem@...emloft.net>,
	Jiri Pirko <jiri@...nulli.us>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [bisected] Re: WARNING: at net/ipv4/devinet.c:1599

On Tue, Feb 4, 2014 at 8:20 PM, Geert Uytterhoeven <geert@...ux-m68k.org> wrote:
> On Tue, Feb 4, 2014 at 7:08 PM, Cong Wang <cwang@...pensource.com> wrote:
>> On Tue, Feb 4, 2014 at 6:19 AM, Geert Uytterhoeven <geert@...ux-m68k.org> wrote:
>>>
>>> Anyone with a clue?
>>>
>>
>> Looks like we need:
>>
>> diff --git a/net/ipv4/devinet.c b/net/ipv4/devinet.c
>> index ac2dff3..bdbf68b 100644
>> --- a/net/ipv4/devinet.c
>> +++ b/net/ipv4/devinet.c
>> @@ -1443,7 +1443,8 @@ static size_t inet_nlmsg_size(void)
>>                + nla_total_size(4) /* IFA_LOCAL */
>>                + nla_total_size(4) /* IFA_BROADCAST */
>>                + nla_total_size(IFNAMSIZ) /* IFA_LABEL */
>> -              + nla_total_size(4);  /* IFA_FLAGS */
>> +              + nla_total_size(4)  /* IFA_FLAGS */
>> +              + nla_total_size(sizeof(struct ifa_cacheinfo)); /*
>> IFA_CACHEINFO */
>>  }
>
> Thanks for your suggestion, but it doesn't help :-(

Bummer, I applied it to the wrong tree.

Yes, it works, thanks a lot!

David, Jiri, is this the right fix, or just a band-aid?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html