lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Thu, 06 Feb 2014 11:57:46 +0100
From:	Marc Kleine-Budde <mkl@...gutronix.de>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
	Florian Vaussard <florian.vaussard@...l.ch>,
	Wolfgang Grandegger <wg@...ndegger.com>
CC:	Andreas Larsson <andreas@...sler.com>, linux-can@...r.kernel.org,
	netdev@...r.kernel.org, sparclinux@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 5/5] can: sja1000: of: add reg-io-width property for
 8, 16 and 32-bit register access

On 01/31/2014 03:08 PM, Sergei Shtylyov wrote:
> Hello.
> 
> On 31-01-2014 17:34, Florian Vaussard wrote:
> 
>> Add the 'reg-io-width' property for 8, 16 and 32-bit access, like
>> what is currently done with IORESOURCE_MEM_{8,16,32}BIT for non-OF
>> boot.
> 
>> Signed-off-by: Florian Vaussard <florian.vaussard@...l.ch>
>> ---
>>   drivers/net/can/sja1000/sja1000_platform.c | 16 ++++++++++++++--
>>   1 file changed, 14 insertions(+), 2 deletions(-)
> 
>> diff --git a/drivers/net/can/sja1000/sja1000_platform.c
>> b/drivers/net/can/sja1000/sja1000_platform.c
>> index 50dece8..25122bf 100644
>> --- a/drivers/net/can/sja1000/sja1000_platform.c
>> +++ b/drivers/net/can/sja1000/sja1000_platform.c
>> @@ -102,8 +102,20 @@ static void sp_populate_of(struct sja1000_priv
>> *priv, struct device_node *of)
>>       int err;
>>       u32 prop;
>>
>> -    priv->read_reg = sp_read_reg8;
>> -    priv->write_reg = sp_write_reg8;
>> +    err = of_property_read_u32(of, "reg-io-width", &prop);
>> +    if (err)
>> +        prop = 1;
>> +
>> +    if (prop == 4) {
> 
>    This is asking to be a *switch* statement instead.

Good point, I'll send a v4.

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


Download attachment "signature.asc" of type "application/pgp-signature" (243 bytes)

Powered by blists - more mailing lists