netdev - Re: [PATCH-net] drivers/net: fix build warning in ethernet/sfc/tx.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52F3BF8F.4080506@solarflare.com>
Date:	Thu, 6 Feb 2014 16:59:59 +0000
From:	Shradha Shah <sshah@...arflare.com>
To:	Paul Gortmaker <paul.gortmaker@...driver.com>
CC:	<netdev@...r.kernel.org>, <linux-net-drivers@...arflare.com>,
	Jon Cooper <jcooper@...arflare.com>,
	Ben Hutchings <bhutchings@...arflare.com>
Subject: Re: [PATCH-net] drivers/net: fix build warning in ethernet/sfc/tx.c

On 02/06/2014 04:45 PM, Paul Gortmaker wrote:
> Commit ee45fd92c739db5b7950163d91dfe5f016af6d24 ("sfc: Use TX PIO
> for sufficiently small packets") introduced the following warning:
> 
> drivers/net/ethernet/sfc/tx.c: In function 'efx_enqueue_skb':
> drivers/net/ethernet/sfc/tx.c:432:1: warning: label 'finish_packet' defined but not used
> 
> Stick the label inside the same #ifdef that the code which calls
> it uses.  Note that this is only seen for arch that do not set
> ARCH_HAS_IOREMAP_WC, such as arm, mips, sparc, ..., as the others
> enable the write combining code and hence use the label.
> 
> Cc: Jon Cooper <jcooper@...arflare.com>
> Cc: Ben Hutchings <bhutchings@...arflare.com>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>

Acked-by: Shradha Shah <sshah@...arflare.com>

> ---
>  drivers/net/ethernet/sfc/tx.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/ethernet/sfc/tx.c b/drivers/net/ethernet/sfc/tx.c
> index c49d1fb16965..75d11fa4eb0a 100644
> --- a/drivers/net/ethernet/sfc/tx.c
> +++ b/drivers/net/ethernet/sfc/tx.c
> @@ -429,7 +429,9 @@ netdev_tx_t efx_enqueue_skb(struct efx_tx_queue *tx_queue, struct sk_buff *skb)
>  	}
>  
>  	/* Transfer ownership of the skb to the final buffer */
> +#ifdef EFX_USE_PIO
>  finish_packet:
> +#endif
>  	buffer->skb = skb;
>  	buffer->flags = EFX_TX_BUF_SKB | dma_flags;
>  
> 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html