netdev - Re: [PATCH-net] drivers/net: fix build warning in ethernet/sfc/tx.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140206.222948.1368580724494519398.davem@davemloft.net>
Date:	Thu, 06 Feb 2014 22:29:48 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	paul.gortmaker@...driver.com
Cc:	netdev@...r.kernel.org, linux-net-drivers@...arflare.com,
	jcooper@...arflare.com, bhutchings@...arflare.com
Subject: Re: [PATCH-net] drivers/net: fix build warning in ethernet/sfc/tx.c

From: Paul Gortmaker <paul.gortmaker@...driver.com>
Date: Thu, 6 Feb 2014 11:45:12 -0500

> Commit ee45fd92c739db5b7950163d91dfe5f016af6d24 ("sfc: Use TX PIO
> for sufficiently small packets") introduced the following warning:
> 
> drivers/net/ethernet/sfc/tx.c: In function 'efx_enqueue_skb':
> drivers/net/ethernet/sfc/tx.c:432:1: warning: label 'finish_packet' defined but not used
> 
> Stick the label inside the same #ifdef that the code which calls
> it uses.  Note that this is only seen for arch that do not set
> ARCH_HAS_IOREMAP_WC, such as arm, mips, sparc, ..., as the others
> enable the write combining code and hence use the label.
> 
> Cc: Jon Cooper <jcooper@...arflare.com>
> Cc: Ben Hutchings <bhutchings@...arflare.com>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html