netdev - Re: [PATCH net-next 2/3] net: phy: allow PHY drivers to implement their own software reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140217.162343.325745613056866328.davem@davemloft.net>
Date:	Mon, 17 Feb 2014 16:23:43 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	f.fainelli@...il.com
Cc:	netdev@...r.kernel.org, Shaohui.Xie@...escale.com
Subject: Re: [PATCH net-next 2/3] net: phy: allow PHY drivers to implement
 their own software reset

From: Florian Fainelli <f.fainelli@...il.com>
Date: Mon, 17 Feb 2014 12:52:45 -0800

> +	if (phydev->drv->soft_reset(phydev))
> +		ret = phydev->drv->soft_reset(phydev);

You're not testing if the method is NULL, you're actually invoking it.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html