netdev - Re: [PATCH net-next 2/3] net: phy: allow PHY drivers to implement their own software reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGVrzcbejiyp1V=FMzLb6fTLyQkzmMLtyakLoikY_6yRhRjduA@mail.gmail.com>
Date:	Mon, 17 Feb 2014 13:34:50 -0800
From:	Florian Fainelli <f.fainelli@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev <netdev@...r.kernel.org>,
	Shaohui Xie <Shaohui.Xie@...escale.com>
Subject: Re: [PATCH net-next 2/3] net: phy: allow PHY drivers to implement
 their own software reset

2014-02-17 13:23 GMT-08:00 David Miller <davem@...emloft.net>:
> From: Florian Fainelli <f.fainelli@...il.com>
> Date: Mon, 17 Feb 2014 12:52:45 -0800
>
>> +     if (phydev->drv->soft_reset(phydev))
>> +             ret = phydev->drv->soft_reset(phydev);
>
> You're not testing if the method is NULL, you're actually invoking it.

That, and there was a typo in the Documentation patch, all fixed now, thanks!
-- 
Florian
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html