netdev - Re: [PATCH] net: ethernet: remove unneeded dependency of mvneta and update help text

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140218165128.5535a9ef@skate>
Date:	Tue, 18 Feb 2014 16:51:28 +0100
From:	Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>
To:	Ezequiel Garcia <ezequiel.garcia@...e-electrons.com>
Cc:	Andrew Lunn <andrew@...n.ch>, Jason Cooper <jason@...edaemon.net>,
	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
	Gregory Clement <gregory.clement@...e-electrons.com>,
	Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] net: ethernet: remove unneeded dependency of mvneta and
 update help text

Dear Ezequiel Garcia,

On Tue, 18 Feb 2014 12:45:12 -0300, Ezequiel Garcia wrote:

> > At the very end of the clean up, when even Orion5x support will be
> > merged in mach-mvebu/, then we can certainly replace these dependencies
> > by a "depends on ARCH_MVEBU". But for the time being, PLAT_ORION seems
> > like the right common denominator for all these platforms.
> > 
> 
> Last time we talked about this with Sebastian and Andrew it was decided
> that the right choice is:
> 
>   MACH_KIRKWOOD || MACH_DOVE || MACH_ARMADA_370_XP

And why not Orion5x and MV78xx0 ?

> 
> Which would become MACH_MVEBU.
> 
> Of course, this is near the nitpick boundary, so AFAIC you can leave
> PLAT_ORION as in v2, if you feel like.

As I suggested previously, PLAT_ORION is what *today* controls the
visibility of all Marvell EBU drivers. Please grep for PLAT_ORION in
your kernel tree. So why on earth would we invent something completely
different for mvneta?

When tomorrow ARCH_MVEBU will be used for all mvebu platforms, then
indeed PLAT_ORION can be changed to ARCH_MVEBU.

Your suggestion above to use MACH_ARMADA_370_XP is *precisely* what
this patch is removing, because MACH_ARMADA_370_XP is being removed
from arch/arm/mach-mvebu/.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html