netdev - Re: [patch] af_packet: remove a stray tab in packet_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <530381AF.7090409@redhat.com>
Date:	Tue, 18 Feb 2014 16:52:15 +0100
From:	Daniel Borkmann <dborkman@...hat.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
CC:	"David S. Miller" <davem@...emloft.net>,
	Willem de Bruijn <willemb@...gle.com>,
	Hannes Frederic Sowa <hannes@...essinduktion.org>,
	Eric Dumazet <edumazet@...gle.com>, Phil Sutter <phil@....cc>,
	Atzm Watanabe <atzm@...atosphere.co.jp>,
	Richard Cochran <richardcochran@...il.com>,
	netdev@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [patch] af_packet: remove a stray tab in packet_set_ring()

On 02/18/2014 01:20 PM, Dan Carpenter wrote:
> At first glance it looks like there is a missing curly brace but
> actually the code works the same either way.  I have adjusted the
> indenting but left the code the same.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Agreed.

Actually, this whole construct could have been simplified ...

     switch (po->tp_version) {
     case TPACKET_V3:
     /* Transmit path is not supported. We checked
      * it above but just being paranoid
      */
         if (!tx_ring)
             init_prb_bdqc(po, rb, pg_vec, req_u, tx_ring);
             break;
     default:
         break;
     }

... into just one if condition. Looks a bit unnecessary as
there's just one case. Feel free to change that as well.

Otherwise ...

Acked-by: Daniel Borkmann <dborkman@...hat.com>

> diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c
> index 6a2bb37506c5..7fd37de503d1 100644
> --- a/net/packet/af_packet.c
> +++ b/net/packet/af_packet.c
> @@ -3786,7 +3786,7 @@ static int packet_set_ring(struct sock *sk, union tpacket_req_u *req_u,
>   		 */
>   			if (!tx_ring)
>   				init_prb_bdqc(po, rb, pg_vec, req_u, tx_ring);
> -				break;
> +			break;
>   		default:
>   			break;
>   		}
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html