netdev - Re: [net-next v2 3/3] cfg80211: add MPLS and 802.21 classification

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <530398B6.2060806@broadcom.com>
Date:	Tue, 18 Feb 2014 18:30:30 +0100
From:	Arend van Spriel <arend@...adcom.com>
To:	David Miller <davem@...emloft.net>,
	<mathias.kretschmer@...us.fraunhofer.de>
CC:	<sw@...onwunderlich.de>, <netdev@...r.kernel.org>,
	<linux-wireless@...r.kernel.org>
Subject: Re: [net-next v2 3/3] cfg80211: add MPLS and 802.21 classification

On 02/17/2014 08:06 PM, David Miller wrote:
> From: "Kretschmer, Mathias" <mathias.kretschmer@...us.fraunhofer.de>
> Date: Mon, 17 Feb 2014 17:34:34 +0000
> 
>> Thought so, as well. But it seems that skb->protocol is not properly
>> set when the packet originates from a packet socket.  And in our
>> case we cannot set it to a fixed etherType in the bind() call since
>> we use three different etherTypes on the same socket.
> 
> So many things break if the skb->protocol isn't set correctly that I
> would consider such SKBs mal-formed.

That was my take as well, but how does the kernel code consider this?

> You can specify the protocol number in the msghdr passed into the
> send.
> 

Regards,
Arend

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html