netdev - Re: [PATCH net-next] tipc: failed transmissions should return error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140218.181128.1171749217306683994.davem@davemloft.net>
Date:	Tue, 18 Feb 2014 18:11:28 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	erik.hugne@...csson.com
Cc:	netdev@...r.kernel.org, tipc-discussion@...ts.sourceforge.net,
	ying.xue@...driver.com, paul.gortmaker@...driver.com,
	jon.maloy@...csson.com, maloy@...jonn.com
Subject: Re: [PATCH net-next] tipc: failed transmissions should return error

From: <erik.hugne@...csson.com>
Date: Tue, 18 Feb 2014 14:29:50 +0100

> From: Erik Hugne <erik.hugne@...csson.com>
> 
> When a message could not be sent out because the destination
> node or link could not be found, the full message size is
> returned from sendmsg() as if it had been sent successfully.
> An application will then get a false indication that it's
> making forward progress. This problem has existed since the
> initial commit in 2.6.16.
> 
> We change this to return -ENETUNREACH if the message cannot be
> delivered due to the destination node/link being unavailable.
> We also get rid of the redundant tipc_reject_msg call since
> freeing the buffer and doing a tipc_port_reject_sections
> accomplishes exactly the same thing.
> 
> Signed-off-by: Erik Hugne <erik.hugne@...csson.com>
> Reviewed-by: Jon Maloy <jon.maloy@...csson.com>

This does not apply cleanly to net-next, please respin.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html