netdev - Re: [PATCH net-next] ieee802154: fix faulty check in set_phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140218.181134.1567312251794761780.davem@davemloft.net>
Date:	Tue, 18 Feb 2014 18:11:34 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	phoebe.buckheister@...m.fraunhofer.de
Cc:	netdev@...r.kernel.org, linux-zigbee-devel@...ts.sourceforge.net
Subject: Re: [PATCH net-next] ieee802154: fix faulty check in
 set_phy_params api

From: Phoebe Buckheister <phoebe.buckheister@...m.fraunhofer.de>
Date: Tue, 18 Feb 2014 14:39:27 +0100

> phy_set_csma_params has a redundant (and impossible) check for
> "retries", found by smatch. The check was supposed to be for
> frame_retries, but wasn't moved during development when
> phy_set_frame_retries was introduced. Also, maxBE >= 3 as required by
> the standard is not enforced.
> 
> Remove the redundant check, assure max_be >= 3 and check -1 <=
> frame_retries <= 7 in the correct function.
> 
> Signed-off-by: Phoebe Buckheister <phoebe.buckheister@...m.fraunhofer.de>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html