netdev - Re: [PATCH net] qeth: postpone freeing of qdio memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140219.164739.1860650180590714358.davem@davemloft.net>
Date:	Wed, 19 Feb 2014 16:47:39 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	blaschka@...ux.vnet.ibm.com
Cc:	netdev@...r.kernel.org, linux-s390@...r.kernel.org
Subject: Re: [PATCH net] qeth: postpone freeing of qdio memory

From: Frank Blaschka <blaschka@...ux.vnet.ibm.com>
Date: Wed, 19 Feb 2014 10:14:51 +0100

> @@ -4919,6 +4919,7 @@ retry:
>  	if (rc)
>  		goto retriable;
>  	rc = qeth_qdio_clear_card(card, card->info.type != QETH_CARD_TYPE_IQD);
> +	qdio_free(CARD_DDEV(card));
>  retriable:
>  	if (rc == -ERESTARTSYS) {
>  		QETH_DBF_TEXT(SETUP, 2, "break1");

You do not want to do the qdio_free() if the qeth_qdio_clear_card() returns
an error value that causes a retry, and yes that can indeed happen.  The halt
paths return things like -ETIME etc.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html