netdev - Re: [PATCH] be2net: Bugfix for packet drop with kernel param swiotlb=force

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140219.164416.129376508868063340.davem@davemloft.net>
Date:	Wed, 19 Feb 2014 16:44:16 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	jiang.biao2@....com.cn
Cc:	netdev@...r.kernel.org, sathya.perla@...lex.com,
	subbu.seetharaman@...lex.com, ajit.khaparde@...lex.com,
	wang.liang82@....com.cn, cai.qu@....com.cn, li.fengmao@....com.cn,
	long.chun@....com.cn
Subject: Re: [PATCH] be2net: Bugfix for packet drop with kernel param
 swiotlb=force

From: jiang.biao2@....com.cn
Date: Wed, 19 Feb 2014 16:25:40 +0800

> +        dma_unmap_page(&adapter->pdev->dev,
> +               dma_unmap_addr(rx_page_info, bus),
> +               rx_frag_size, DMA_FROM_DEVICE);

This is not indented properly.

Arguments on the second and subsequent lines of a function call must
start exactly at the first column after the openning parenthesis of the
function call on the first line.

You must use the appropriate number of TAB and SPACE characters
necessary to do so.

If you are indenting only using TAB characters, you are doing it wrong.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html