netdev - Re: [PATCH v2 net-next] ethtool: Remove inactive code snippet in ethtool_set_rxfh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140219.164243.2046477353509124098.davem@davemloft.net>
Date:	Wed, 19 Feb 2014 16:42:43 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	VenkatKumar.Duvvuru@...lex.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH v2 net-next] ethtool: Remove inactive code snippet in
 ethtool_set_rxfh_indir

From: Venkat Duvvuru <VenkatKumar.Duvvuru@...lex.com>
Date: Wed, 19 Feb 2014 13:20:25 +0530

> ethtool_rxfh_indir_default is invoked inside ethtool_set_rxfh_indir when
> user_size is zero. However user_size can only be zero when dev_size is
> zero in which case ethtool_get_rxfh_indir itself would return
> EOPNOTSUPP error. "user_size = 0" can never happen unless userspace
> ethtool sends user_size as zero beforing invoking the ioctl for
> ETHTOOL_SRSSH, in which case we should return -EINVAL.
> 
> v2: Modified commit message.
> 
> Signed-off-by: Venkat Duvvuru <VenkatKumar.Duvvuru@...lex.com>

It looks like the author of this code intended user_size == 0 as a way
to reset the indirection table to the default, did this ever work?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html