netdev - RE: [PATCH v2 net-next] ethtool: Remove inactive code snippet in ethtool_set_rxfh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BF3270C86E8B1349A26C34E4EC1C44CB2C87E699@CMEXMB1.ad.emulex.com>
Date:	Fri, 21 Feb 2014 10:28:24 +0000
From:	Venkata Duvvuru <VenkatKumar.Duvvuru@...lex.Com>
To:	David Miller <davem@...emloft.net>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH v2 net-next] ethtool: Remove inactive code snippet in
 ethtool_set_rxfh_indir

> From: Venkat Duvvuru <VenkatKumar.Duvvuru@...lex.com>
> Date: Wed, 19 Feb 2014 13:20:25 +0530
> 
> > ethtool_rxfh_indir_default is invoked inside ethtool_set_rxfh_indir
> > when user_size is zero. However user_size can only be zero when
> > dev_size is zero in which case ethtool_get_rxfh_indir itself would
> > return EOPNOTSUPP error. "user_size = 0" can never happen unless
> > userspace ethtool sends user_size as zero beforing invoking the ioctl
> > for ETHTOOL_SRSSH, in which case we should return -EINVAL.
> >
> > v2: Modified commit message.
> >
> > Signed-off-by: Venkat Duvvuru <VenkatKumar.Duvvuru@...lex.com>
> 
> It looks like the author of this code intended user_size == 0 as a way to reset
> the indirection table to the default, did this ever work?

There is no option for --set-rxfh-indir to reset the indirection table. So ethtool cannot know that it has to fill user_size = 0 to reset the indirection table to default.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html